On Thu, 25 May 2023 04:46:04 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which proposes to improve the >> accessibility of the thread dump files that are generated by the `jcmd >> Thread.dump_to_file` command configured in the failure handler >> configurations? This addresses https://bugs.openjdk.org/browse/JDK-8308475. >> >> The changes in this PR include: >> - Enhancement to `GatherProcessInfoTimeoutHandler` to allow configuring a >> `successArtifacts` action parameter which can be used to generate links to >> files that are generated by the failure handler commands. >> - Introduction of a `%iterCount` token to allow ability to refer to the >> current iteration when the command is repeated >> - The `jcmd Thread.dump_to_file` is now configured to create the thread >> dumps in `json` format. Additionally, it has now been configured to create >> the thread dumps 6 times, just like the `jstack` command. >> >> Detailed explanation of the `successArtifacts` parameter and the >> `%iterCount` token is provided in the JBS comment here >> https://bugs.openjdk.org/browse/JDK-8308475?focusedCommentId=14583072&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14583072 >> >> Tests have been run locally with this change and tier1, tier2 and tier3 >> tests on CI system to verify this change works and doesn't cause regression. > > Thank you Leonid for the review. > > Since this is tagged hotspot, can I please get a second Reviewer to review > this please? > @jaikiran I don't know why @AlanBateman tagged this as Hotspot as there are > no hotspot related changes. Perhaps it was just for visibility of shared > failure handler changes? config/mailinglist/rules/jdk.json (in the skara repo) maps changes test/failure_handler/ to core-libs but changes to the jtreg failure handler are of wider interest. It looks like changes to the handler have previously been cc'ed to the hotspot list too. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14071#issuecomment-1562490146
