On Sun, 21 May 2023 09:19:47 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this change which proposes to improve the > accessibility of the thread dump files that are generated by the `jcmd > Thread.dump_to_file` command configured in the failure handler > configurations? This addresses https://bugs.openjdk.org/browse/JDK-8308475. > > The changes in this PR include: > - Enhancement to `GatherProcessInfoTimeoutHandler` to allow configuring a > `successArtifacts` action parameter which can be used to generate links to > files that are generated by the failure handler commands. > - Introduction of a `%iterCount` token to allow ability to refer to the > current iteration when the command is repeated > - The `jcmd Thread.dump_to_file` is now configured to create the thread > dumps in `json` format. Additionally, it has now been configured to create > the thread dumps 6 times, just like the `jstack` command. > > Detailed explanation of the `successArtifacts` parameter and the `%iterCount` > token is provided in the JBS comment here > https://bugs.openjdk.org/browse/JDK-8308475?focusedCommentId=14583072&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14583072 > > Tests have been run locally with this change and tier1, tier2 and tier3 tests > on CI system to verify this change works and doesn't cause regression. Here's how the link to the thread dump file will look like with these current changes, in the processes.html: <img width="1581" alt="processes html" src="https://github.com/openjdk/jdk/assets/143523/131ffec4-6411-4c63-8f05-d47ebb9151d5";> ------------- PR Comment: https://git.openjdk.org/jdk/pull/14071#issuecomment-1556129202
