On Tue, 16 May 2023 15:14:03 GMT, Ichiroh Takiguchi <itakigu...@openjdk.org> wrote:
>> According to "JDK 20 Internationalization Guide" >> https://docs.oracle.com/en/java/javase/20/intl/supported-encodings.html >> Following Solaris related Japanese charsets are in "contained in >> jdk.charsets module" list. >> >> - PCK (x-PCK) >> - EUC_JP_Solaris (x-eucJP-Open) >> >> These are not supported by Linux platform, so they should not be in >> java.base module. >> >> Note: >> GHA Linux x86 builds were failed. >> I think it's not related by my modified code. >> I opened [JDK-8308051](https://bugs.openjdk.org/browse/JDK-8308051) GHA: >> Linux x86 builds failure > > Ichiroh Takiguchi has updated the pull request incrementally with one > additional commit since the last revision: > > 8308046: Move Solaris related Japanese charsets from java.base to > jdk.charsets module src/jdk.charsets/share/classes/sun/nio/cs/ext/EUC_JP_Open.java.template line 71: > 69: private static final DoubleByte.Decoder DEC0208 = > 70: (DoubleByte.Decoder)new JIS_X_0208().newDecoder(); > 71: Can these also be removed, by making those original ones in `EUC_JP` public? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13973#discussion_r1197162002
