On Tue, 16 May 2023 15:14:03 GMT, Ichiroh Takiguchi <itakigu...@openjdk.org> wrote:
>> According to "JDK 20 Internationalization Guide" >> https://docs.oracle.com/en/java/javase/20/intl/supported-encodings.html >> Following Solaris related Japanese charsets are in "contained in >> jdk.charsets module" list. >> >> - PCK (x-PCK) >> - EUC_JP_Solaris (x-eucJP-Open) >> >> These are not supported by Linux platform, so they should not be in >> java.base module. >> >> Note: >> GHA Linux x86 builds were failed. >> I think it's not related by my modified code. >> I opened [JDK-8308051](https://bugs.openjdk.org/browse/JDK-8308051) GHA: >> Linux x86 builds failure > > Ichiroh Takiguchi has updated the pull request incrementally with one > additional commit since the last revision: > > 8308046: Move Solaris related Japanese charsets from java.base to > jdk.charsets module I now think it is better simply removing Solaris-related charsets, as moving them from java.base to jdk.charsets would require unnecessary code changes in non-Solaris code. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13973#issuecomment-1550062543
