On Wed, 10 May 2023 20:28:11 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default >> collation for Swedish to the modern one. In order to provide a means for >> users who need the old collation, this PR intends to make `Collator` >> recognize the `co` Unicode locale extension so that multiple implementations >> for a locale can be provided. I would also like reviews for the >> corresponding CSR. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > http -> https src/java.base/share/classes/java/text/Collator.java line 131: > 129: * </blockquote> > 130: * may return a {@code Collator} instance with the traditional sorting, > which > 131: * gives 'v' and 'w' the same sorting order. The overall intent and wording looks okay but I wonder if it should be in the getInstance methods instead. Also wondering whether impNote is right because it's both informational for developers using the API and useful to implementors. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13917#discussion_r1190915577
