On Wed, 10 May 2023 22:30:13 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> Ok, since this is loading a `long` (which represents an address that points >> into the code cache) I think we're fine without using the access API then? > > Correct. The code had been written for the previous version of Shenandoah > (1.0). No current GC uses barriers for non-oop types and the C++ Runtime > doesn't support it any more as Stefan pointed out. > It is still possible to use the access API on other platforms, but it does > nothing more than a plain load/store for non-oop types. I'm ok with doing a plain access. I don't like the difference to other ports as it will at least waste time of people with less expertise in the area (e.g. new to the project). No need to continue the discussion in this pr though. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12708#discussion_r1190812209
