On Wed, 10 May 2023 14:26:54 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> FWIW, since Shenandoah changed their load barriers we have been cleaning >> away the usages of the Access API for loads and stores to primitive values. >> There's no such support in the C++ Runtime code. > > Ok, since this is loading a `long` (which represents an address that points > into the code cache) I think we're fine without using the access API then? Correct. The code had been written for the previous version of Shenandoah (1.0). No current GC uses barriers for non-oop types and the C++ Runtime doesn't support it any more as Stefan pointed out. It is still possible to use the access API on other platforms, but it does nothing more than a plain load/store for non-oop types. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12708#discussion_r1190447075
