On Thu, 13 Apr 2023 07:42:24 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:
>> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 75 commits: >> >> - Merge branch 'master' into 8285932 >> - Change MAX_INDY_CONCAT_ARG_SLOTS to be updatable. >> - Clean up Error handling >> - Recommended changes >> - RuntimeException is the only exception type that can is deduced from a >> lambda. >> - Update combine example >> - Merge branch 'master' into 8285932 >> - Update StringTemplate.combine javadoc >> - Requested review changes. >> - Clean up list construction >> - ... and 65 more: https://git.openjdk.org/jdk/compare/bc151633...f1b187a1 > > src/java.base/share/classes/java/lang/runtime/ReferenceKey.java line 113: > >> 111: @Override >> 112: public String toString() { >> 113: return "java.util.WeakKey#" + System.identityHashCode(this); > > Why `java.util` ? It's a bit misleading Moved and not reflected in the string. Changing to `this.getClass().getCanonicalName() + "#" + System.identityHashCode(this);` > src/java.base/share/classes/java/lang/runtime/ReferenceKey.java line 172: > >> 170: @Override >> 171: public String toString() { >> 172: return "java.util.SoftKey#" + System.identityHashCode(this); > > Why `java.util` ? It's a bit misleading same > src/java.base/share/classes/java/lang/runtime/ReferenceKey.java line 226: > >> 224: @Override >> 225: public String toString() { >> 226: return "java.util.StrongKey#" + >> System.identityHashCode(this); > > Why `java.util` ? It's a bit misleading same > src/java.base/share/classes/java/lang/runtime/StringTemplateImpl.java line > 130: > >> 128: } >> 129: >> 130: @java.lang.Override > > Suggestion: > > @Override One of those IntelliJ things - ugh. > src/java.base/share/classes/java/lang/runtime/StringTemplateImpl.java line > 131: > >> 129: >> 130: @java.lang.Override >> 131: public java.lang.String toString() { > > Suggestion: > > public String toString() { same > src/java.base/share/classes/java/util/FormatItem.java line 71: > >> 69: MethodType.methodType(MethodHandle.class, >> long.class)); >> 70: >> 71: private static final long charMix(long lengthCoder, char value) { > > let's drop `final` modifier from `static` methods Changing ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1165449867 PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1165450204 PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1165450363 PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1165452561 PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1165452753 PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1165456644
