On Wed, 12 Apr 2023 20:50:35 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:
>> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 75 commits: >> >> - Merge branch 'master' into 8285932 >> - Change MAX_INDY_CONCAT_ARG_SLOTS to be updatable. >> - Clean up Error handling >> - Recommended changes >> - RuntimeException is the only exception type that can is deduced from a >> lambda. >> - Update combine example >> - Merge branch 'master' into 8285932 >> - Update StringTemplate.combine javadoc >> - Requested review changes. >> - Clean up list construction >> - ... and 65 more: https://git.openjdk.org/jdk/compare/bc151633...f1b187a1 > > src/java.base/share/classes/java/lang/runtime/Carriers.java line 286: > >> 284: */ >> 285: MethodHandle constructor(CarrierShape carrierShape) { >> 286: int longCount = carrierShape.longCount(); > > `longCount`/`intCount` seems unused in this method Changing > src/java.base/share/classes/java/lang/runtime/Carriers.java line 369: > >> 367: * Cache mapping {@link MethodType} to previously defined >> {@link CarrierElements}. >> 368: */ >> 369: private static Map<MethodType, CarrierElements> > > Can it be made `final` ? Changing > src/java.base/share/classes/jdk/internal/access/JavaTemplateAccess.java line > 28: > >> 26: package jdk.internal.access; >> 27: >> 28: import java.lang.invoke.MethodHandle; > > Couple of unused imports Changing ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1165440095 PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1165439152 PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1165442266
