On Fri, 31 Mar 2023 22:06:34 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> Pleases review this PR. >> The PR includes the following changes. >> - tzdata 2023c >> - Hack code to deal with Cairo's DST end, which is same as done in >> 2014g([JDK-8049343](https://bugs.openjdk.org/browse/JDK-8049343)). To work >> around the the limitation of JSR 310 compiler, where the time 24:00 is >> recognized as 0:00 in the previous day. > > src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java line 742: > >> 740: >> 741: return new ZoneInfo(zoneId, rawOffset, dstSavings, checksum, >> transitions, >> 742: offsets, params, willGMTOffsetChange); > > do we need to change it here? No need. It was reformatted by IntelliJ editor. The original code is better from perspective of the OpenJDK's standard code style. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13255#discussion_r1156543028
