On Fri, 31 Mar 2023 00:02:02 GMT, Yoshiki Sato <ysato...@openjdk.org> wrote:
> Pleases review this PR. > The PR includes the following changes. > - tzdata 2023c > - Hack code to deal with Cairo's DST end, which is same as done in > 2014g([JDK-8049343](https://bugs.openjdk.org/browse/JDK-8049343)). To work > around the the limitation of JSR 310 compiler, where the time 24:00 is > recognized as 0:00 in the previous day. Looks good overall. Please fix a couple of editorial errors. Changes requested by naoto (Reviewer). src/java.base/share/data/tzdata/antarctica line 1: > 1: # Extra space src/java.base/share/data/tzdata/northamerica line 1: > 1: src/java.base/share/data/tzdata/northamerica # ??? copy/paste error? ------------- Changes requested by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13255#pullrequestreview-1367269723 PR Review: https://git.openjdk.org/jdk/pull/13255#pullrequestreview-1367273595 PR Review Comment: https://git.openjdk.org/jdk/pull/13255#discussion_r1154692139 PR Review Comment: https://git.openjdk.org/jdk/pull/13255#discussion_r1154689466
