On Wed, 22 Mar 2023 08:09:03 GMT, Xiaohong Gong <xg...@openjdk.org> wrote:
>> Quan Anh Mai has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - missing casts >> - clean up > > Please also update the copyright to 2023 for some touched files like > `vectorSupport.hpp` and other java files like `AbstractShuffle.java`, > `AbstractVector.java`, `VectorShape.java`, and `VectorShuffle.java`. Thanks! > @XiaohongGong Thanks, I have updated the copyright year and the code styles > as you suggested Thanks for your update! > I also noticed that the similar shuffle cast code is used more frequently. > Could we wrap such code `toShuffle().cast(vspecies())` to a separate method? And for this, is it possible to wrap such code in a single method? ------------- PR Comment: https://git.openjdk.org/jdk/pull/13093#issuecomment-1480494762
