On Wed, 22 Mar 2023 12:39:27 GMT, Quan Anh Mai <qa...@openjdk.org> wrote:
>> src/hotspot/share/opto/vectorIntrinsics.cpp line 2426:
>>
>>> 2424: if (is_vector_shuffle(vbox_klass_from)) {
>>> 2425: return false; // vector shuffles aren't supported
>>> 2426: }
>>
>> Is it better to change this as an "assertion" or print the log details?
>
> The change indifferentiates a vector shuffle from a normal vector in C2, so
> this should be removed, as vector shuffles are converted to/from normal
> vector using this routine
Oh, I'm sorry that I didn't notice it is a removing change. And, yes, you're
right. So please ignore my previous comment. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13093#discussion_r1145580975
