On Tue, 14 Mar 2023 15:49:56 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> Proposing accessor methods to Emoji properties defined in [Unicode Technical 
>> Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character` 
>> class. This is per a request from the client group, as well as refining the 
>> currently existing ad-hoc emoji implementation in regex. A CSR has also been 
>> drafted, and I would appreciate reviews for it too.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fixed method descriptions

make/jdk/src/classes/build/tools/generatecharacter/GenerateCharacter.java line 
215:

> 213:         maskEmojiComponent  = 0x040000000000L,
> 214:         maskExtendedPictographic = 0x080000000000L;
> 215: 

Would be nice the have the '=' aligned in the same column as the ones above, or 
at least have the emoji ones align with each other.

-------------

PR: https://git.openjdk.org/jdk/pull/13006

Reply via email to