On Mon, 13 Mar 2023 21:16:24 GMT, Naoto Sato <na...@openjdk.org> wrote:

> Proposing accessor methods to Emoji properties defined in [Unicode Technical 
> Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character` 
> class. This is per a request from the client group, as well as refining the 
> currently existing ad-hoc emoji implementation in regex. A CSR has also been 
> drafted, and I would appreciate reviews for it too.

src/java.base/share/classes/java/lang/Character.java line 10803:

> 10801:     /**
> 10802:      * Determines if the specified character (Unicode code point) has 
> the
> 10803:      * Emoji Presentation by default.

"has the Emoji Presentation", should that be "has the Emoji Presentation 
property"?

src/java.base/share/classes/java/lang/Character.java line 10887:

> 10885:      * @since   21
> 10886:      */
> 10887:     public static boolean isExtendedPictographic(int codePoint) {

Is there a "cut 'n paste" error here, it looks like the description has been 
copied from  isEmojiComponent.

-------------

PR: https://git.openjdk.org/jdk/pull/13006

Reply via email to