On Fri, 3 Mar 2023 06:56:57 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> Last and certainly not least in the port of FDLIBM to Java, the >> transcendental methods for sin, cos, and tan. >> >> Some more tests are to be written in the StrictMath directory to verify that >> the StrictMath algorihtm for sin/cos/tan is being used rather than a >> different one. However, I wanted to get the rest of the change out for >> review first. >> >> The sin/cos/tan methods are grouped together since they share the same >> argument reduction logic. Argument reduction is the process of mapping an >> argument of a function to an argument in a restricted range (and possibly >> returning some function of the reduced argument). For sin, cos, and tan, >> since they are fundamentally periodic with respect to a multiple of pi, >> argument reduction is done to find the remainder of the original argument >> with respect to pi/2. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Add more tests. Approved for integration once other reviewers concerns have been addressed. ------------- Marked as reviewed by bpb (Reviewer). PR: https://git.openjdk.org/jdk/pull/12800
