On Thu, 15 Dec 2022 07:02:37 GMT, Jaikiran Pai <[email protected]> wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Swapping deprecations in properties
>
> test/jdk/tools/jlink/plugins/CompressorPluginTest.java line 203:
>
>> 201: if (e.getMessage().contains("Invalid compression level")) {
>> 202: return;
>> 203: }
>
> Should we print the stacktrace if the message is not the one we expect, to
> help debug any failures? Or perhaps rethrow the exception to cause the test
> to fail?
if it matches the expected message, it's okay not to print the stacktrace. If
it does not match, this can simply rethrow instead of line 206 throwing a new
exception IMO.
-------------
PR: https://git.openjdk.org/jdk/pull/11617
