On Mon, 6 Feb 2023 20:12:09 GMT, Ian Graves <igra...@openjdk.org> wrote:
>> This is an approach to adding a flag to jlink that will allow --compress to >> take the same types of arguments as jmod, thus bringing the two into >> alignment. This likely requires a CSR and a discussion on whether we should >> deprecate or simply remove the original numeric compression arguments. > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Adding plugin type to force compact strings vs zip ordering src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/CompactConstantPoolsPlugin.java line 44: > 42: public final class CompactConstantPoolsPlugin extends AbstractPlugin > implements ResourcePrevisitor { > 43: > 44: private static final String FILTER = "filter"; Should we perhaps just reference the already `public` `DefaultCompressPlugin.FILTER` field instead of redefining it here? ------------- PR: https://git.openjdk.org/jdk/pull/11617