On Thu, 15 Dec 2022 07:31:05 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> test/jdk/tools/jlink/plugins/CompressorPluginTest.java line 153: >> >>> 151: Properties optionsZip0 = new Properties(); >>> 152: DefaultCompressPlugin compressPluginZip0 = new >>> DefaultCompressPlugin(); >>> 153: options0.setProperty(compressPluginZip0.getName(), "zip-0"); >> >> I suspect this supposed to be `optionsZip0.setProperty(....)` instead of >> `options0.setProperty(....)`? > > I think, there's also a typo in the next line: > > checkCompress(classes, compressPlugin, > > should have been: > > checkCompress(classes, compressPluginZip0, > > I haven't yet looked at the existing test code in `checkCompress` method, but > it might need a closer look as to why this test passed. I would have expected > it to fail due to the typos. @jaikiran is right. This test is to set up `optionsZip0` and `compressPluginZip0` to verify `zip-0`. ------------- PR: https://git.openjdk.org/jdk/pull/11617
