On Tue, 14 Feb 2023 18:01:44 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> I meant that an attribute can have zeros in the non-header portion of the >> attribute data. > > Got it. How about we change this comment from: > > // - Even though ATTRIBUTE_END is used to mark the end of the attribute > stream, > // streams will contain zero byte values to represent lesser significant > bits. > // Thus, detecting a zero byte is not sufficient to detect the end of an > attribute > // stream. > > > to: > > // - Even though ATTRIBUTE_END (which might be encoded as a zero byte) is > used to > // mark the end of the attribute stream, streams will contain zero byte > values in the > // non-header portion of the attribute data. Thus, detecting a zero byte > is not > // sufficient to detect the end of an attribute stream. > > > ? The phrase "to represent lesser significant bits" and mention of > `ATTRIBUTE_END` is throwing me off. Sounds good to me. ------------- PR: https://git.openjdk.org/jdk/pull/12533
