On Tue, 14 Feb 2023 17:10:32 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> @JimLaskey OK. Perhaps we can be clearer what is meant here exactly. I was >> having a hard time deciphering this. It does say `stream will contain zero >> byte values to represent lesser significant bits`. **What** are "byte values >> to represent lesser significant bits"? > > To me it sounded like it wanted to say: Since the `ATTRIBUTE_END` isn't a > full byte (only 5 bits in a byte), it might be represented as a non-zero > value. For example a byte containing `0x07` would equally be `ATTRIBUTE_END` > as would a zero byte or a `0x01` byte. `ATTRIBUTE_END` is a `kind` which is > encoded with the *most* significant `5` bits. Yet, `ATTRIBUTE_END` isn't a > full byte. The least significant `3` bits in the byte represent the `length - > 1` - of bytes - in the attribute stream for offset values. That, to me, also > would suggest that comparing it to a zero byte value is not sufficient to > detect `ATTRIBUTE_END`. I meant that an attribute can have zeros in the non-header portion of the attribute data. ------------- PR: https://git.openjdk.org/jdk/pull/12533
