On Mon, 13 Feb 2023 20:20:22 GMT, Lance Andersen <[email protected]> wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert accidental removal of UTF8ZipCoder.compare
>
> test/jdk/java/util/zip/ZipFile/InvalidBytesInEntryNameOrComment.java line 90:
>
>> 88: expectedExceptionsMessageRegExp = BAD_ENTRY_NAME_OR_COMMENT)
>> 89: public void shouldRejectInvalidName() throws IOException {
>> 90: try (ZipFile zf = new ZipFile(invalidName.toFile())) {
>
> If you could please convert to use `expectThrows` to get to validate the
> message name
The message is already validated using `expectedExceptionsMessageRegExp` in the
`@Test` annotation.
Would you prefer if I use expectThrows instead, or perhaps inline the
`BAD_ENTRY_NAME_OR_COMMENT` constant as a literal?
-------------
PR: https://git.openjdk.org/jdk/pull/12290
