On Thu, 26 Jan 2023 12:07:20 GMT, Alan Bateman <al...@openjdk.org> wrote:
> Thanks for the updates/iterations, I think you've got this to a good place. > > One thing to think about is having System.initPhase3 read file.encoding and > if not UTF-8, it could call Charset.defaultCharset and if not the expected > value then it could emit a warning like is done for a bad value of > java.io.tmpdir. > > One thing is whether to add a regression test to ensure that the default > charset is UTF-8 when run with -Dfile.encoding=XXX and XXX is in the service > provider module. Filed: https://bugs.openjdk.org/browse/JDK-8301199 > src/java.base/share/classes/java/nio/charset/Charset.java line 632: > >> 630: >> 631: @Stable >> 632: private static Charset defaultCharset; > > Style wise, I think the annotation is added between the private and static > modifiers in other places. Fixed. ------------- PR: https://git.openjdk.org/jdk/pull/12171
