> This issue was found during the review of this PR: 
> https://github.com/openjdk/jdk/pull/12132 where `Charset` class was 
> loaded/initialized at the phase 1 of the startup process. Since `Charset` 
> depends on `StaticProperty`, loading of `Charset` class should be delayed. I 
> basically moved cache for `jnuCharset` into the actual calling locations 
> `ProcessImpl` and `ProcessEnvironment` for unix platforms so that 
> initPhase1() won't initialize `Charset` class.
> Unrelated, but I replaced `Locale.ENGLISH` with `Locale.ROOT` in the argument 
> of `toLowerCase()`.

Naoto Sato has updated the pull request incrementally with one additional 
commit since the last revision:

  Remove unnecessary import

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12171/files
  - new: https://git.openjdk.org/jdk/pull/12171/files/c0a6770c..df999de3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12171&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12171&range=05-06

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/12171.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12171/head:pull/12171

PR: https://git.openjdk.org/jdk/pull/12171

Reply via email to