On Sun, 15 Jan 2023 01:56:06 GMT, Jie Fu <ji...@openjdk.org> wrote: >> src/java.desktop/share/native/libharfbuzz/hb-meta.hh line 191: >> >>> 189: #define hb_int_max(T) hb_int_max<T>::value >>> 190: >>> 191: #if defined(__GNUC__) && __GNUC__ < 5 && !defined(__clang__) >> >> Normally, such changes in third-party libraries need to be done upstream, >> and not locally. @prrace can confirm. > >> Normally, such changes in third-party libraries need to be done upstream, >> and not locally. @prrace can confirm. > > Thanks @kevinrushforth for your review. > > Yes, it had been fixed in the upstream and I just follow it. > Please see https://github.com/harfbuzz/harfbuzz/blob/main/src/hb-meta.hh#L202 > . > > Or did you mean we had to sync the whole harfbuzz with the upstream? > If so, I would suggest doing it in a separate PR. > What do you think? > Thanks.
No, I didn't mean to update all of harfbuzz. What you've done seems fine to me, but let's see what @prrace says. ------------- PR: https://git.openjdk.org/jdk/pull/12005
