On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu <ji...@openjdk.org> wrote: > Hi all, > > Please review the fix for the build failure with clang-15. > > 1. -Wbitwise-instead-of-logical > > 1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the > warning > 2) src/hotspot/share/runtime/notificationThread.cpp <--- keep the code > and disable warnings > 3) src/hotspot/share/runtime/serviceThread.cpp <--- keep the code > and disable warnings > > > 2. -Wdeprecated-non-prototype (all the warnings are disabled) > > 1) Mainly caused by files under `src/java.base/share/native/libzip/zlib/` > <--- keep the code and disable warnings > It occurred while building LIBJLI, LIBZIP and LIBSPLASHSCREEN. > > 2) While compiling > src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c <--- keep > the code and disable warnings > > 3) Caused by src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m > <--- fixed the warnings > > > 3. -Wdeprecated-builtins > > Caused by files under src/java.desktop/share/native/libharfbuzz/ <--- > fixed the warnings > > Ref: https://github.com/harfbuzz/harfbuzz/blob/main/src/hb-meta.hh#L202 > > 4. -Wgnu-folding-constant > > Caused by > src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderer.m <--- > keep the code and disable warnings > > > Thanks. > Best regards, > Jie
src/java.desktop/share/native/libharfbuzz/hb-meta.hh line 191: > 189: #define hb_int_max(T) hb_int_max<T>::value > 190: > 191: #if defined(__GNUC__) && __GNUC__ < 5 && !defined(__clang__) Normally, such changes in third-party libraries need to be done upstream, and not locally. @prrace can confirm. ------------- PR: https://git.openjdk.org/jdk/pull/12005
