On Thu, 29 Sep 2022 16:47:01 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> I am sorry to misunderstand your comment. >> >> I don’t know whether "é"(0x00e9) exists only in "Cp1252", "UTF-8". >> Will that be no problem that this test is skipped in other encordings? If >> skipped, the pattern for its encording probably won't be added forever. I >> think the other pattern should be added when this test fails. However I will >> follow the policy of OpenJDK. > > I agree skipping the test is not the best solution. Leaving a hint in the > comments on how to fix the issue looks better alternative. Well, what concerns me with the current fix is that it is simply patching only the case for the Japanese setup. We don't know if the same failure would happen in other setups (I'm pretty sure the same failure would happen with some Chinese Windows setups) which makes the test fragile. If that happens, we are not sure if it is a real bug or a test case false positive at a glance. For that reason, I think we should only run tests on the setup where we are sure the false positive won't happen (by skipping other unknown host encodings). And for the purpose of this test, that should suffice the need. Another option would be to actually check if the test string can be encoded with a CharsetEncoder, but that may be overkill. ------------- PR: https://git.openjdk.org/jdk/pull/10226
