> Could you please review the JDK-8293579 bug fixes?
>
> tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to give
> the launcher the character which is encoded by Windows API
> WideCharToMultiByte()
> from UNICODE "é"(0x00e9) as an argument. However, this test fails because the
> code point "é"(0x00e9) cannot be treated on Japanese Windows.
>
> WideCharToMultiByte() encodes characters as Shift-JIS on Japanese Windows,
> but
> the code point "é"(0x00e9) does not exist in Shift-JIS, and it is replaced
> with
> "e"(0x0065) as substitute. Therefore, "é"(0x00e9) and "e"(0x0065) are
> compared
> in this test and judged to be different characters, and return as failed.
>
> So, in the Japanese encoding("MS932", "SJIS"), the test should be modified to
> give a character such as "あ"(0x3042) as the launcher's argument instead of
> "é"(0x00e9).
KIRIYAMA Takuya has updated the pull request incrementally with one additional
commit since the last revision:
8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java fails
on Japanese Windows platform
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/10226/files
- new: https://git.openjdk.org/jdk/pull/10226/files/476c1a0c..2baff408
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=10226&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=10226&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/10226.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/10226/head:pull/10226
PR: https://git.openjdk.org/jdk/pull/10226
