On Fri, 23 Sep 2022 18:32:57 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   1. addressed review comments from Chris; added VirtualThread.java update 
>> from Alan
>
> src/hotspot/share/prims/jvmtiThreadState.cpp line 273:
> 
>> 271: 
>> 272:     assert(!thread->is_in_tmp_VTMS_transition(), "sanity check");
>> 273:     assert(!thread->is_in_VTMS_transition(), "VTMS_transition sanity 
>> check");
> 
> Why not cover both of these with `!thread->is_in_any_VTMS_transition()`?

It is to be clear what condition caused the assert as they are different beasts.

-------------

PR: https://git.openjdk.org/jdk/pull/10321

Reply via email to