On Mon, 19 Sep 2022 20:46:12 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> I'm the author of these comments and basically the entire source file. >> >> You are right, it will work without the additional overloads. However the >> null pointers will be ignored (tested with G++ 7.4.0), but this is minor, >> probably implementation-specific and can be ignored. > > Strange, on my end gcc doesn't mind NULL being passed (though this may be due > to a different gcc version being used), guess it's probably implementation > specific like you mentioned Correct, it allows NULL to be passed. G++ 7.4.0 ignores it and doesn't append anything to the buffer, while msvc back when this code was created appended a "null" string to the buffer. ------------- PR: https://git.openjdk.org/jdk/pull/10231
