On Mon, 19 Sep 2022 19:17:06 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> I deliberately left those 2 out since the comments accompanying them seem to >> suggest that they're Windows specific overloads that are there for different >> reasons (As opposed to the one this PR is aimed at, which takes in a regular >> std::wstring), moreover not providing overloads for them don't seem to be >> causing issues either. I'm unsure if adding them too would be correct, I'll >> wait for more reviews before doing so > > I'm the author of these comments and basically the entire source file. > > You are right, it will work without the additional overloads. However the > null pointers will be ignored (tested with G++ 7.4.0), but this is minor, > probably implementation-specific and can be ignored. Strange, on my end gcc doesn't mind NULL being passed (though this may be due to a different gcc version being used), guess it's probably implementation specific like you mentioned ------------- PR: https://git.openjdk.org/jdk/pull/10231
