On Fri, 16 Sep 2022 13:02:16 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Hi, >> >> @dumasun reported the issue: >> >> Configured with jfx-ls-modular-sdk: >> >> >> configure --with-import-modules=modular-sdk >> >> >> `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` >> failed: >> >> >> ----------System.err:(11/697)---------- >> java.lang.RuntimeException: JavaFX modules erroneously included in the JDK >> at FXLauncherTest.main(FXLauncherTest.java:451) >> at >> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) >> at java.base/java.lang.reflect.Method.invoke(Method.java:578) >> at >> com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) >> at java.base/java.lang.Thread.run(Thread.java:1589) >> >> JavaTest Message: Test threw exception: java.lang.RuntimeException: JavaFX >> modules erroneously included in the JDK >> JavaTest Message: shutting down test >> >> STATUS:Failed.`main' threw exception: java.lang.RuntimeException: JavaFX >> modules erroneously included in the JDK >> >> >> Thanks, >> Leslie Zhai > > It does seem worth trying `--patch-module` if the javafx.graphics module is > present in the Java runtime. If that works, it is better than skipping the > test, since you will then be able to continue testing the FX launcher. > > Another possibility would be to go with your proposed solution of skipping > the test if the javafx.graphics module is present, and provide a second test > that is only run when the `javafx.graphics` module is present. In that case, > you could test the actual FX launcher rather than the dummy implementation. > This could either be done in this PR or as a follow-on test bug. Hi @kevinrushforth @AlanBateman I have tried `--upgrade-module-path` and `--patch-module` but still failed. Please point out my fault if I misunderstanding. Thanks, Leslie Zhai ------------- PR: https://git.openjdk.org/jdk/pull/10299
