On Sat, 17 Sep 2022 04:03:35 GMT, Leslie Zhai <lz...@openjdk.org> wrote:
>> Hi,
>>
>> @dumasun reported the issue:
>>
>> Configured with jfx-ls-modular-sdk:
>>
>>
>> configure --with-import-modules=modular-sdk
>>
>>
>> `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"`
>> failed:
>>
>>
>> ----------System.err:(11/697)----------
>> java.lang.RuntimeException: JavaFX modules erroneously included in the JDK
>> at FXLauncherTest.main(FXLauncherTest.java:451)
>> at
>> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
>> at java.base/java.lang.reflect.Method.invoke(Method.java:578)
>> at
>> com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
>> at java.base/java.lang.Thread.run(Thread.java:1589)
>>
>> JavaTest Message: Test threw exception: java.lang.RuntimeException: JavaFX
>> modules erroneously included in the JDK
>> JavaTest Message: shutting down test
>>
>> STATUS:Failed.`main' threw exception: java.lang.RuntimeException: JavaFX
>> modules erroneously included in the JDK
>>
>>
>> Thanks,
>> Leslie Zhai
>
> Leslie Zhai has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8293910: Try --upgrade-module-path and --patch-module but still failed
test/jdk/tools/launcher/FXLauncherTest.java line 249:
> 247: fxCmds.add(2, "--add-modules=javafx.graphics");
> 248: } else {
> 249: fxCmds.add(1, "--upgrade-module-path=" + IMPORT_MODULE_DIR);
Hi @kevinrushforth @AlanBateman
Please point out my fault if I misunderstanding.
Thanks,
Leslie Zhai
-------------
PR: https://git.openjdk.org/jdk/pull/10299
