On Tue, 16 Aug 2022 17:34:58 GMT, Volker Simonis <simo...@openjdk.org> wrote:
>> The problem is that after >> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) we call `fill()` >> unconditionally (and before calling `Inflater::inflate()`) in >> `InflaterInputStream::read()` if `Inflater::needsInput()` is true. This >> misses the case where the native inflater has consumed all its input (i.e. >> `Inflater::needsInput()` returns true) but hasn't managed to write all the >> inflated data into the output buffer (e.g. because it was to small). In rare >> cases, there might be now more input available (i.e. calling >> `InflaterInputStream::fill()` will throw an `EOFException`) but we still >> have to call `Inflater::inflate()` to consume the buffered output from the >> underlying native inflater until inflation stops. >> >> The documentation of the `inflate()` method in `zlib.h` mentions this >> explicitely: >> >>> "If `inflate()` returns `Z_OK` and with zero `avail_out`, it must be called >>> again after making room in the output buffer because there might be more >>> output pending." > > Volker Simonis has updated the pull request incrementally with one additional > commit since the last revision: > > Changed the payload to a more innocent version This looks OK Volker. It would be nice if possible to add another test or two prior to pushing as an extra sanity check. If not, a follow on would be ideal. I assume you have run Mach1-3 and the JCK tests for extra sanity? ------------- Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.org/jdk/pull/9881
