On Wed, 22 Jun 2022 18:19:56 GMT, Roger Riggs <rri...@openjdk.org> wrote:
> The RuntimeException from OutputAnalyzer for expected and unexpected exit > values should include both the actual and expected values. > The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the > value expected and the value not expected instead of the actual value > returned. The values provided in the exception are already known quantities > in the code, what is not known is the actual value. > The actual value is printed to stderr but not the expected value and in the > logs, the exception report is frequently to stdout and therefor separated in > the log from the output of stderr. Including both expected and actual values > in the exception makes it easier to understand. > > Exception messages should not include newlines. This pull request has now been integrated. Changeset: fdc8455c Author: Roger Riggs <rri...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/fdc8455c4559a5513c46cb61bdf09f8279d44192 Stats: 47 lines in 2 files changed: 27 ins; 1 del; 19 mod 8288495: [test] Make OutputAnalyzer exception more informative Reviewed-by: lmesnik, naoto, jpai, dholmes ------------- PR: https://git.openjdk.org/jdk/pull/9247
