> The RuntimeException from OutputAnalyzer for expected and unexpected exit > values should include both the actual and expected values. > The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the > value expected and the value not expected instead of the actual value > returned. The values provided in the exception are already known quantities > in the code, what is not known is the actual value. > The actual value is printed to stderr but not the expected value and in the > logs, the exception report is frequently to stdout and therefor separated in > the log from the output of stderr. Including both expected and actual values > in the exception makes it easier to understand. > > Exception messages should not include newlines.
Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Revert change to shouldNotHaveExitValue Correct OutputAnalyzerTest ------------- Changes: - all: https://git.openjdk.org/jdk/pull/9247/files - new: https://git.openjdk.org/jdk/pull/9247/files/4e479b4a..e73bf2bd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=9247&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9247&range=00-01 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/9247.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9247/head:pull/9247 PR: https://git.openjdk.org/jdk/pull/9247
