[
https://issues.apache.org/jira/browse/HADOOP-19134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874627#comment-17874627
]
ASF GitHub Bot commented on HADOOP-19134:
-----------------------------------------
hadoop-yetus commented on PR #6692:
URL: https://github.com/apache/hadoop/pull/6692#issuecomment-2295173953
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 11m 19s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 56 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 13s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 31m 55s | | trunk passed |
| +1 :green_heart: | compile | 16m 19s | | trunk passed with JDK
Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 |
| +1 :green_heart: | compile | 14m 55s | | trunk passed with JDK
Private Build-1.8.0_422-8u422-b05-1~20.04-b05 |
| +1 :green_heart: | checkstyle | 4m 8s | | trunk passed |
| +1 :green_heart: | mvnsite | 17m 6s | | trunk passed |
| +1 :green_heart: | javadoc | 14m 55s | | trunk passed with JDK
Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 |
| +1 :green_heart: | javadoc | 14m 51s | | trunk passed with JDK
Private Build-1.8.0_422-8u422-b05-1~20.04-b05 |
| +1 :green_heart: | spotbugs | 27m 42s | | trunk passed |
| +1 :green_heart: | shadedclient | 34m 1s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 10m 26s | | the patch passed |
| +1 :green_heart: | compile | 15m 48s | | the patch passed with JDK
Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 |
| +1 :green_heart: | javac | 15m 48s | | the patch passed |
| +1 :green_heart: | compile | 14m 56s | | the patch passed with JDK
Private Build-1.8.0_422-8u422-b05-1~20.04-b05 |
| +1 :green_heart: | javac | 14m 56s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 4m 1s |
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/8/artifact/out/results-checkstyle-root.txt)
| root: The patch generated 2 new + 3896 unchanged - 66 fixed = 3898 total
(was 3962) |
| +1 :green_heart: | mvnsite | 17m 7s | | the patch passed |
| +1 :green_heart: | javadoc | 14m 46s | | the patch passed with JDK
Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 |
| +1 :green_heart: | javadoc | 14m 51s | | the patch passed with JDK
Private Build-1.8.0_422-8u422-b05-1~20.04-b05 |
| +1 :green_heart: | spotbugs | 32m 16s | | the patch passed |
| +1 :green_heart: | shadedclient | 33m 49s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 19m 1s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 3m 39s | | hadoop-kms in the patch passed.
|
| +1 :green_heart: | unit | 218m 53s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | unit | 1m 20s | | hadoop-yarn-api in the patch
passed. |
| +1 :green_heart: | unit | 5m 47s | | hadoop-yarn-common in the patch
passed. |
| +1 :green_heart: | unit | 3m 48s | | hadoop-yarn-server-common in
the patch passed. |
| +1 :green_heart: | unit | 103m 22s | |
hadoop-yarn-server-resourcemanager in the patch passed. |
| +1 :green_heart: | unit | 24m 29s | | hadoop-yarn-server-nodemanager
in the patch passed. |
| +1 :green_heart: | unit | 28m 14s | | hadoop-yarn-client in the patch
passed. |
| +1 :green_heart: | unit | 8m 15s | | hadoop-mapreduce-client-core in
the patch passed. |
| +1 :green_heart: | unit | 1m 29s | | hadoop-mapreduce-client-common
in the patch passed. |
| +1 :green_heart: | unit | 8m 47s | | hadoop-mapreduce-client-app in
the patch passed. |
| +1 :green_heart: | unit | 4m 21s | | hadoop-mapreduce-client-hs in
the patch passed. |
| +1 :green_heart: | unit | 124m 57s | |
hadoop-mapreduce-client-jobclient in the patch passed. |
| +1 :green_heart: | unit | 22m 1s | | hadoop-distcp in the patch
passed. |
| +1 :green_heart: | unit | 0m 55s | | hadoop-yarn-server-router in
the patch passed. |
| +1 :green_heart: | unit | 1m 18s | | hadoop-mapreduce-examples in
the patch passed. |
| +1 :green_heart: | unit | 7m 10s | | hadoop-streaming in the patch
passed. |
| +1 :green_heart: | unit | 0m 57s | | hadoop-rumen in the patch
passed. |
| +1 :green_heart: | unit | 1m 3s | | hadoop-datajoin in the patch
passed. |
| +1 :green_heart: | unit | 3m 4s | | hadoop-aws in the patch passed.
|
| +1 :green_heart: | asflicense | 1m 16s | | The patch does not
generate ASF License warnings. |
| | | 961m 26s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.44 ServerAPI=1.44 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/8/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6692 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 1d17b58d662e 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9
15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 1b6c7bcde4e623372105a2bd197b4c1a0be78e72 |
| Default Java | Private Build-1.8.0_422-8u422-b05-1~20.04-b05 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
/usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
|
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/8/testReport/ |
| Max. process+thread count | 3878 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common
hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
hadoop-tools/hadoop-distcp
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router
hadoop-mapreduce-project/hadoop-mapreduce-examples
hadoop-tools/hadoop-streaming hadoop-tools/hadoop-rumen
hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-aws U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6692/8/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> use StringBuilder instead of StringBuffer
> -----------------------------------------
>
> Key: HADOOP-19134
> URL: https://issues.apache.org/jira/browse/HADOOP-19134
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: PJ Fanning
> Assignee: PJ Fanning
> Priority: Major
> Labels: pull-request-available
>
> StringBuilder is basically the same as StringBuffer but doesn't use
> synchronized. String appending rarely needs locking like this.
> There are some public and package private APIs that use StringBuffers as
> input or return types - I have left these alone for compatibility reasons.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
