[
https://issues.apache.org/jira/browse/HADOOP-19134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874591#comment-17874591
]
ASF GitHub Bot commented on HADOOP-19134:
-----------------------------------------
pjfanning commented on code in PR #6692:
URL: https://github.com/apache/hadoop/pull/6692#discussion_r1720844527
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestTextOutputFormat.java:
##########
@@ -165,68 +165,68 @@ public void testFormatWithCustomSeparator() throws
Exception {
*/
@Test
public void testCompress() throws IOException {
- JobConf job = new JobConf();
Review Comment:
I've committed a change that reverts everything in this file since it is
just a test class.
> use StringBuilder instead of StringBuffer
> -----------------------------------------
>
> Key: HADOOP-19134
> URL: https://issues.apache.org/jira/browse/HADOOP-19134
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: PJ Fanning
> Assignee: PJ Fanning
> Priority: Major
> Labels: pull-request-available
>
> StringBuilder is basically the same as StringBuffer but doesn't use
> synchronized. String appending rarely needs locking like this.
> There are some public and package private APIs that use StringBuffers as
> input or return types - I have left these alone for compatibility reasons.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
