[
https://issues.apache.org/jira/browse/HADOOP-19134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874506#comment-17874506
]
ASF GitHub Bot commented on HADOOP-19134:
-----------------------------------------
pjfanning commented on PR #6692:
URL: https://github.com/apache/hadoop/pull/6692#issuecomment-2294863658
The tests are passing in the CI build but I am getting issues due to
formatting checks. Some of the files are already incorrectly formatted. In this
commit, I reformatted a whole file to try to silence the CI warnings but this
is now the biggest part of the PR diff.
https://github.com/apache/hadoop/pull/6692/commits/bf731f880eac79688b50c98e5c0e05b96d36c1e6
> use StringBuilder instead of StringBuffer
> -----------------------------------------
>
> Key: HADOOP-19134
> URL: https://issues.apache.org/jira/browse/HADOOP-19134
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: PJ Fanning
> Assignee: PJ Fanning
> Priority: Major
> Labels: pull-request-available
>
> StringBuilder is basically the same as StringBuffer but doesn't use
> synchronized. String appending rarely needs locking like this.
> There are some public and package private APIs that use StringBuffers as
> input or return types - I have left these alone for compatibility reasons.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
