> On 19 Sep 2017, at 16:55, Allen Wittenauer <a...@effectivemachines.com> wrote: > > >> On Sep 19, 2017, at 6:48 AM, Brahma Reddy Battula >> <brahmareddy.batt...@huawei.com> wrote: >> >> Can we run "mvn install" and "compile" for all the modules after applying >> the patch(we can skip shadeclients) > > We need to get over this idea that precommit is going to find all > problems every time. Committers actually do need to spend some time with a > patch. Besides, in this particular case, it was shading that actually broke… >
> which really makes me want to remove -DskipShade from the pom.xmls. It’s > clearly getting abused. please dont What we could do is have a patch submission process which says "if you are playing with packaging, you must declare at the time of patch submission that you have run a full mvn clean install". And a commit process which says "if you commit a patch which changes the packaging, you need to do a build before a test" This is a variant of what we expect for the hadoop-aws and hadoop-azure clients where the submitter has to state the endpoint they ran the integration test suite against. Committer is expected to rerun the test suite locally before the commit too, for safety And we should all be trying 'mvn package -Pdist,native" regularly too, and playing with the new scripts. We need to find the issues before anyone else For all this to work, of course, we need reproducible builds. I see my mornings build is asking for "json-smart-2.3-SNAPSHOT.pom" as well as the doxia stuff. Why is so much -SNAPSHOT stuff getting in? I don't even see a ref for json-smart in our POMs
