> On Sep 19, 2017, at 6:48 AM, Brahma Reddy Battula > <brahmareddy.batt...@huawei.com> wrote: > > Can we run "mvn install" and "compile" for all the modules after applying the > patch(we can skip shadeclients)
We need to get over this idea that precommit is going to find all problems every time. Committers actually do need to spend some time with a patch. Besides, in this particular case, it was shading that actually broke… which really makes me want to remove -DskipShade from the pom.xmls. It’s clearly getting abused. --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org