On Tue, Sep 19, 2017 at 8:55 AM, Allen Wittenauer <a...@effectivemachines.com> wrote: > We need to get over this idea that precommit is going to find all > problems every time. Committers actually do need to spend some time with a > patch. Besides, in this particular case, it was shading that actually broke… > which really makes me want to remove -DskipShade from the pom.xmls. It’s > clearly getting abused.
The downstream testing will help, particularly running against shaded artifacts [1]. Precommit should replace as many of the rote tasks as possible, particularly checks on invariants like shading. Computers are good at checking this. Humans are not only bad at it, it's tedious as hell. Particularly repeating it in every branch. Again, let's continue disabling, deleting, and reverting changes that make the CI infra unstable. Precommit is doing its job, but garbage-in, garbage-out. -C [1] https://issues.apache.org/jira/browse/HADOOP-13916 --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org
