kenhuuu commented on code in PR #3401: URL: https://github.com/apache/tinkerpop/pull/3401#discussion_r3169246390
########## docs/src/dev/developer/for-committers.asciidoc: ########## @@ -385,7 +385,12 @@ appropriate types expected by the tests. The syntax of the type notation involves a prefix character to help denote the type, a value between two square brackets, optionally suffixed with some additional notation depending on the primary type. +* Binary - *bin[_xxx_]* - The "xxx" should be replaced with a base64-encoded string. +* Character - *char[_xxx_]* - The "xxx" should be replaced with a single UTF-8 character. * Date - *dt[_xxx_]* - The "xxx" should be ISO 8601 string. +* Duration - *dur[_xxx_,_yyy_,_zzz_]* - The "xxx" should be replaced a Long representing seconds, the "yyy" should be +replaced an Int representing nanoseconds, and the optional "zzz" should be replaced by a boolean which is true if the +value is positive and false if its negative. * Edge - *e[_xxx_]* - The "xxx" should be replaced with a representation of an edge in the form of the Review Comment: We didn't seem to do that for any of the other `@Data...` test files. Any particular reason you think it would be valuable to do this here? I'm assuming that at some point these data types will be used in other feature files so having these tags mentioned would be kind of pointless. You would probably want a `@SupportsChar` or something later? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
