kenhuuu commented on code in PR #3401:
URL: https://github.com/apache/tinkerpop/pull/3401#discussion_r3169182275
##########
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/language/grammar/GeneralLiteralVisitorTest.java:
##########
@@ -238,6 +241,11 @@ public static Iterable<Object[]> generateTestParameters() {
{"'abc\\u2300def'", "abc\u2300def"},
{"'\u2300'", "\u2300"},
{"'abc\u2300def'", "abc\u2300def"},
+ // explicit 's' suffix for string literals
+ {"\"hello\"s", "hello"},
+ {"'hello's", "hello"},
+ {"\"\"s", "Empty"},
Review Comment:
Yes, but its part of the test definition.
```
if (expected.equals("Empty")) {
// handle special case for Empty string
assertEquals("", new GenericLiteralVisitor(new
GremlinAntlrToJava()).visitStringLiteral(ctx));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
