kenhuuu commented on code in PR #3401: URL: https://github.com/apache/tinkerpop/pull/3401#discussion_r3169230283
########## gremlin-language/src/main/antlr4/Gremlin.g4: ########## @@ -2500,6 +2520,26 @@ SignedInfLiteral // String Literals +// Character literal is a single character string with a 'c' suffix, modeled after printf's %c. +// Must appear before NonEmptyStringLiteral for longest-match priority. +CharacterLiteral + : '"' DoubleQuotedStringCharacter '"' 'c' + | '\'' SingleQuotedStringCharacter '\'' 'c' Review Comment: Maybe? That's probably a good idea. The way I have it set up right now follows printf where c/C and s/S are different things where wide-characters are a thing. But I guess since we are UTF-8 only, it does make sense to have it more consistent within the grammar. Let me think about this some more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
