sharpca commented on PR #13081: URL: https://github.com/apache/seatunnel/pull/13081#issuecomment-6609328522
Thanks for the re-review, and no apology needed — you caught your own two carryovers before I did, which is more than most reviews do. On **CI**: agreed, and it is the only thing left. I have the fork build on me, not on a maintainer: `sharpca/seatunnel` still reports zero registered workflows (`GET /repos/sharpca/seatunnel/actions/workflows` → `total_count: 0`, `.../actions/runs` → `0`), and `gh workflow run Build --ref fix/cli-enum-locale` fails with "could not find any workflows named Build". So the workflows are simply not enabled on the fork yet; once I flip that switch in the fork's Actions tab, I will run `Build` for `fix/cli-enum-locale` (and for #13083) and the PR checks should adopt those runs. I will post the run links here rather than describe them. On **Item A** (`UsageFormatter.java:84`): you are right, and I confirmed it on dev — it is the only case conversion in that file, `java.util.Locale` is not even imported there, and `String displayText = type.isEnum() ? def.toString().toLowerCase() : def.toString();` will print `clıent` for a `client` default under tr-TR. I agree it does not belong in this PR, which is otherwise done: I have it prepared as a one-line `Locale.ROOT` change plus the import and the reformat that the 100-column limit forces. I will open it as a separate small PR once this one has merged, so this PR can land as soon as the build is green. Thanks also for confirming the four `CheckpointStatus` constants and that the branch does not need a sync at 3 ahead / 8 behind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
