sharpca commented on PR #13081:
URL: https://github.com/apache/seatunnel/pull/13081#issuecomment-6559209190
All three issues are addressed in `3dc5920e`.
**Issue 1 — CRLF / `git diff --check` (blocking)** — the ten files are LF
now:
- Net diff against `dev` for the same ten files went from `+1042/-831` to
`+268/-7`.
- The blob, not just the working tree: `DeployMode.java` at `3dc5920e` is
2306 bytes with 0 CR and 66 LF; the compare patch for this head contains no CR.
- `git diff --check` is clean for the new commit.
Worth recording why it happened and why the naive fix is not enough: the
repository has no `*.java` rule in `.gitattributes`, and `core.autocrlf` is
`true` on this Windows checkout, so `spotless:apply` writes CRLF back into the
working tree even after normalisation. I applied the formatter first,
normalised afterwards, and committed through the index, which is why the
committed blobs are LF.
**Issue 2 — contracts (blocking)** — `DeployMode.from` now documents that it
folds with `Locale.ROOT` and returns an empty `Optional` for `null` and unknown
tokens, and the three regression classes have class Javadoc naming the
production behaviour they protect. The description now states explicitly that
the `null` correction applies on **every** locale, not only
Turkish/Azerbaijani, and that the launcher converters keep their existing
throwing behaviour.
**Issue 3 — locale isolation** — all four locale-mutating tests capture the
base, `DISPLAY` and `FORMAT` defaults, restore all three in `finally`, and
carry `@ResourceLock("java.util.Locale")`.
**Verification** (JDK 17, the four affected modules): `DeployModeTest` 2,
`FlinkCommandArgsConverterTest` 3, `SparkCommandArgsConverterTest` 2,
`ConnectorCheckCommandArgsTest` 2 — 9 tests, 0 failures. `spotless:check`
passes.
Still open on my side: current-head CI is `action_required`, so none of this
has executed in Actions; that gate needs a maintainer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
