SEZ9 commented on issue #13022: URL: https://github.com/apache/seatunnel/issues/13022#issuecomment-6485897740
Thanks @SEPURI-SAI-KRISHNA, that matches what I had in mind, and good to hear the PR was already underway. On the points you listed: - Normalizing the type name (trim, cut at `(`, upper-case with `Locale.ROOT`) before the switch is the right fix for `decimal(10, 2)` falling through to STRING. One thing I'd like to confirm: since the parenthesized part is stripped before matching, the precision and scale still need to be read from the original string so the `DECIMAL` branch keeps 10 and 2 rather than a default precision. Could you confirm that, and that the test asserts the actual precision and scale rather than only the type? - `BINARY`/`VARBINARY` -> `PrimitiveByteArrayType.INSTANCE` is correct and lines up with both the docs and `toDatabendTypeString`. - Repeating the mapping under `tr-TR` and `az-AZ` in `DatabendCatalogTest` is a nice touch given the `Locale.ROOT` change. Thanks for the note on the fork build at `8884fee49`. Once you've confirmed the precision/scale handling I'll review the PR directly. <!-- streview-comment:2102 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
