SEZ9 commented on issue #13022: URL: https://github.com/apache/seatunnel/issues/13022#issuecomment-6459647752
Thanks for the detailed analysis. Since you've offered to submit a PR, please go ahead. A fix that normalizes the type name before the switch (so the parenthesized precision/scale no longer prevents the `DECIMAL` branch from matching), changes the `BINARY`/`VARBINARY` branch to `PrimitiveByteArrayType.INSTANCE` to match the docs and `toDatabendTypeString`, and uses `Locale.ROOT` for the uppercasing would address all three points. A unit test that feeds `decimal(10, 2)` and `binary` into `convertDatabendType` and asserts the expected SeaTunnel types would be a good regression guard. <!-- streview-comment:2091 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
