Vivek1106-04 commented on PR #12165: URL: https://github.com/apache/seatunnel/pull/12165#issuecomment-6474788525
Thanks @DanielLeens for the re-review and for confirming Issues 5 and 6. **CI on `a932e27a7` (fork run [40463705801](https://github.com/Vivek1106-04/seatunnel/actions/runs/40463705801)):** I checked the logs for both non-green jobs. Neither one is a test failure: - `rocketmq-connector-it (17)`: every test that ran passed. The job ended with `The runner has received a shutdown signal ... The operation was canceled.` (08:23:53Z). The runner was stopped mid-job. - `all-connectors-it-4 (11)`: every reported module passed (the last was `EdgeSocketCheckpointRestoreIT`, 6/6, 0 failures). The job was cancelled at 09:25:45Z, 150 minutes after it started at 06:55:25Z, so it hit the job time limit. I re-ran the failed jobs (attempt 2) and will post the result here. **Issue 1 (other deferred `handleCoordinatorError` callers without a generation token):** agreed. I will follow up with a separate issue and PR. The PR will route the asynchronous barrier-trigger/completion failure handlers and the scheduled-trigger wrapper through an owner-checked overload under `generationLock`, with controlled-reset regression tests like the expiry ones. That keeps this PR's scope unchanged. I will also pick up Issue 3 (`expireCheckpoint` package-private with `@VisibleForTesting`) and the savepoint-poll interaction test from Issue 2 there, because both touch the same code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
